fix: remove "kvStoreKeys" check cosmosanalysis.go

[sashaduke]

Fixes #3850.

Since this function is only present in the app.go file of freshly scaffolded SDK v0.50+ blockchains, checking for this prevents backwards compatibility with blockchains scaffolded before SDK v0.50.
I have simply removed the line as it's not needed.

[julienrbrt]

Hi, thanks for your PR, can you add e2e tests with a v0.47 app?
Additionally, can you add a changelog?

[sashaduke]

Hi @julienrbrt, I'm not too familiar with your testing setup - are you referring to this? https://github.com/ignite/cli/tree/main/integration

Happy to add a changelog

[julienrbrt]

Hi @julienrbrt, I'm not too familiar with your testing setup - are you referring to this? https://github.com/ignite/cli/tree/main/integration

Happy to add a changelog

Yes, can be here: https://github.com/ignite/cli/blob/main/integration/chain/cmd_serve_test.go.

Or maybe simpler and better, we can add a unit test for a v0.47 app.go here: https://github.com/ignite/cli/blob/v28.1.0/ignite/pkg/cosmosanalysis/cosmosanalysis_test.go / https://github.com/ignite/cli/blob/v28.1.0/ignite/pkg/cosmosanalysis/app/testdata

Please do add a changelog, thanks!

[sashaduke]

@julienrbrt should be good to go now!

[julienrbrt]

I guess this is fine to merge this and update the test in a follow-up.

See above

[sashaduke]

Sorry @julienrbrt, I've had lots on my plate this week I'm afraid. Happy to merge this now and come back to improve the tests when I have a bit more free time!

[julienrbrt]

tACK.