fix: restore runtime app API registered module discovery

[jeronimoalbi]

Fixes #3783

[jeronimoalbi]

@clockworkgr I think that the TS client code is properly generated but there are other issues with the TS client itself I believe. Would you be able to take a look?

I got these errors:

cosmos.base.tendermint.v1beta1/module.ts(15,10): error TS2440: Import declaration conflicts with local declaration of 'Module'.
cosmos.base.tendermint.v1beta1/module.ts(366,43): error TS2339: Property 'fromPartial' does not exist on type '(test: IgniteClient) => { module: { CosmosBaseTendermintV1Beta1: SDKModule; }; registry: [string, GeneratedType][]; }'.
cosmos.base.tendermint.v1beta1/module.ts(620,79): error TS2339: Property 'fromPartial' does not exist on type '(test: IgniteClient) => { module: { CosmosBaseTendermintV1Beta1: SDKModule; }; registry: [string, GeneratedType][]; }'.

It seems that the fix is a quick one, there is a symbol name clash.

[clockworkgr]

We're still missing modules here:

nft
upgrade
feegrant
ibc core
ibc channel
ibc connection

[jeronimoalbi]

We're still missing modules here:

nft upgrade feegrant ibc core ibc channel ibc connection

The IBC ones are not discovered because there is a different wiring for them until they are updated, I'm working on changes to discover them.

A part from that nft, feegrant and upgrade are standalone Go modules now, imported from cosmossdk.io so that might be related to the issue, but I'm not sure yet.

@clockworkgr have you noticed other missing modules?

[clockworkgr]

Just those 6 I think

[jeronimoalbi]

I think the TS client generation issues are solved already but the CI checks are taking really long to complete. I'm not sure if it's only this PR or is a general issue with the runners.

With these changes the "cosmossdk.io/x" Go packages search proto files within the Cosmos SDK Go package because these packages don't have the proto files included so they can't otherwise be discovered.

Custom wired IBC modules from the app/ibc.go file are discovered too.

TS client generated code was missing some modules which are now generated, like tx, feegrant, upgrade, the ibc.core ones and a couple others.

I will remove the Draft status and sync with main once the CI checks pass successfully.

[jeronimoalbi]

@clockworkgr would you take a look to the TS generated code?

I see that all the modules are generated now but we are missing some TS client fixes.
Do you want to push the fixes to this branch or will you create a different PR?

[clockworkgr]

@clockworkgr would you take a look to the TS generated code?

I see that all the modules are generated now but we are missing some TS client fixes. Do you want to push the fixes to this branch or will you create a different PR?

Ok..

There is one bug with how npm install treats the symlinked client which is part of the ignite/web templates. I'll look into it and fix it.

There are the ts template updates which I'm going to push here.

But the most important issue has to do with the module filepath for the cosmossdk.io modules.

Here:

cli/ignite/pkg/cosmosgen/template.go

Lines 71 to 75 in 5f55d40

	"resolveFile": func(fullPath string) string {
	rel, _ := filepath.Rel(protoPath, fullPath)
	rel = strings.TrimSuffix(rel, ".proto")
	return rel
	},

this worked to "copy" the folder structure of the proto files into the types/ subfolder. to refer to the appropriate generated types.

For the cosmossdk.io ones, this now results in things like:
import { SoftwareUpgradeProposal } from "./types/../../../../github.com/cosmos/[email protected]/proto/cosmos/upgrade/v1beta1/upgrade";

instead of:
import { SoftwareUpgradeProposal } from "./types/cosmos/upgrade/v1beta1/upgrade";

Any ideas how to best fix this?

[jeronimoalbi]

Any ideas how to best fix this?

Working on it 👍

Update: Fixed in b9b090a

[clockworkgr]

Any ideas how to best fix this?

Working on it 👍

Update: Fixed in b9b090a

Ok. Will check and confirm

[clockworkgr]

Seems to generate all modules except for NFT.. Is that expected? do we add nft to keepers by default?

I see an issue where the Paginated field of HTTPQueries is not set properly and all queries come up as non-paginated...Not sure where that error stems from though

[jeronimoalbi]

Seems to generate all modules except for NFT.. Is that expected? do we add nft to keepers by default?

Yes, the NFT module is not scaffolded by default.

I see an issue where the Paginated field of HTTPQueries is not set properly and all queries come up as non-paginated...Not sure where that error stems from though

This one I'm not sure. I remember seeing someone mentioning an issue with the pagination but I can't find the issue. Maybe we can deal with it in a new issue?

[clockworkgr]

Seems to generate all modules except for NFT.. Is that expected? do we add nft to keepers by default?

Yes, the NFT module is not scaffolded by default.

ok then

I see an issue where the Paginated field of HTTPQueries is not set properly and all queries come up as non-paginated...Not sure where that error stems from though

This one I'm not sure. I remember seeing someone mentioning an issue with the pagination but I can't find the issue. Maybe we can deal with it in a new issue?

Ok, we can do that. But def needs sorting out. Along with updating the web templates once cosmjs patch is released