fix: use better default rpc #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
salmad3,
toschdev,
ilgooz,
jeronimoalbi,
Pantani and
Ehsan-saradar
as code owners
|
Visit the preview URL for this PR (updated for commit 22d21c4): https://igntservices-docs--pr3748-julien-better-defaul-yit4f9s6.web.app (expires Tue, 21 Nov 2023 20:06:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
julienrbrt
commented
Nov 13, 2023
|
@julienrbrt, can you please add a changelog? |
Pantani
previously approved these changes
Nov 14, 2023
ilgooz
previously approved these changes
Nov 14, 2023
julienrbrt
commented
Nov 14, 2023
ilgooz
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while testing
ignite nodewhile reviewing #3659.The default RPC ignite uses does not exist (https://rpc.cosmos.network/).
Use the RPC proxy from cosmos.directory instead (never had problem with it personally).
An alternative would be to have Ignite running its own infra for this, but tbh, I do not see the point, when there are good one available.