fix(protoanalysis): fix wrong parser for proto package names #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
added 2 commits
November 3, 2023 11:37
jeronimoalbi
reviewed
Nov 6, 2023
jeronimoalbi
previously approved these changes
Nov 6, 2023
Co-authored-by: Jerónimo Albi <[email protected]>
jeronimoalbi
approved these changes
Nov 6, 2023
Ehsan-saradar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we parse the proto files, we are trying to resolve the proto package name, getting the last name from the namespace, but some packages have the version in the end. For instance,
cosmos.staking.v1beta1is returningv1beta1as the name of the proto package. This PR solves the issue of getting the last valid name by removing the version.