feat: create a wrapper for errors #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
julienrbrt
reviewed
Nov 6, 2023
julienrbrt
reviewed
Dec 6, 2023
Pantani
dismissed stale reviews from Ehsan-saradar and jeronimoalbi
via
7f804ec
julienrbrt
reviewed
Dec 8, 2023
# Conflicts: # ignite/cmd/plugin.go
|
Just merged the bump PR, I think you'll need to fix the changelog again here. Sorry 😀 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3723 +/- ##
=======================================
Coverage 24.31% 24.32%
=======================================
Files 292 293 +1
Lines 24532 24538 +6
=======================================
+ Hits 5966 5968 +2
- Misses 18030 18033 +3
- Partials 536 537 +1
|
julienrbrt
reviewed
Dec 12, 2023
julienrbrt
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3237
Description
This PR creates a
xerrorspackage to wrap the cockroachdb error pkg. We can easily manage and maintain the application errors. In case to change or improve the pkg, we only need to change one file