feat: add test suite for the cli tests #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
jeronimoalbi
reviewed
Nov 6, 2023
Comment on lines
+30
to
+38
| func (s *IntegrationTestSuite) SetupTest() { | ||
| s.T().Log("setting up test") | ||
| s.cfg = network.DefaultConfig() | ||
| } | ||
|
|
||
| func (s *IntegrationTestSuite) SetupSuite() { | ||
| s.T().Log("setting up integration test suite") | ||
| s.cfg = network.DefaultConfig() | ||
| } |
There was a problem hiding this comment.
Not sure but wouldn't it make sense to set the config per test and remove the config initialization from the suite?
There was a problem hiding this comment.
We are setting the config per test, but since we have a global config we are resetting the config for each test
jeronimoalbi
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mutex lock into the package
cosmos-sdk/testutil/network/networkis blocking the CLI tests into a scaffolded ChainSolution
Move to the suite test
This PR also speeds up the chain and Ignite integration tests