chore(deps): bump postcss from 8.4.21 to 8.4.31 in /docs #3685

dependabot · 2023-10-07T15:15:54Z

Bumps postcss from 8.4.21 to 8.4.31.

Release notes

8.4.31

Fixed \r parsing to fix CVE-2023-44270.

8.4.30

Improved source map performance (by @romainmenke).

8.4.29

Fixed Node#source.offset (by @idoros).

Fixed docs (by @coliff).

8.4.28

Fixed Root.source.end for better source map (by @romainmenke).

Fixed Result.root types when process() has no parser.

8.4.27

Fixed Container clone methods types.

8.4.26

Fixed clone methods types.

8.4.25

Improve stringify performance (by @romainmenke).

Fixed docs (by @vikaskaliramna07).

8.4.24

Fixed Plugin types.

8.4.23

Fixed warnings in TypeDoc.

8.4.22

Fixed TypeScript support with node16 (by @remcohaszing).

Changelog

Sourced from postcss's changelog.

8.4.31

Fixed \r parsing to fix CVE-2023-44270.

8.4.30

Improved source map performance (by Romain Menke).

8.4.29

Fixed Node#source.offset (by Ido Rosenthal).

Fixed docs (by Christian Oliff).

8.4.28

Fixed Root.source.end for better source map (by Romain Menke).

Fixed Result.root types when process() has no parser.

8.4.27

Fixed Container clone methods types.

8.4.26

Fixed clone methods types.

8.4.25

Improve stringify performance (by Romain Menke).

Fixed docs (by @vikaskaliramna07).

8.4.24

Fixed Plugin types.

8.4.23

Fixed warnings in TypeDoc.

8.4.22

Fixed TypeScript support with node16 (by Remco Haszing).

Commits

90208de Release 8.4.31 version
58cc860 Fix carrier return parsing
4fff8e4 Improve pnpm test output
cd43ed1 Update dependencies
caa916b Update dependencies
8972f76 Typo
11a5286 Typo
45c5501 Release 8.4.30 version
bc3c341 Update linter
b2be58a Merge pull request #1881 from romainmenke/improve-sourcemap-performance--phil...
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.

julienrbrt · 2023-10-08T09:03:04Z

Weird that CI tries to deploy on PRs.
I think that step should by skipped on PRs?

jeronimoalbi · 2023-10-09T07:36:48Z

Weird that CI tries to deploy on PRs. I think that step should by skipped on PRs?

It's necessary to check that the dependency update doesn't break the docs I think.
In any case it seems there is a configuration issue here with Firebase.

@mazzy89

mazzy89 · 2023-10-09T07:41:42Z

@jeronimoalbi I will check. Please bear with me. It was not me configuring the CI job deploying to Firebase so need to dive deep there first.

julienrbrt · 2023-10-09T07:45:18Z

Weird that CI tries to deploy on PRs. I think that step should by skipped on PRs?

It's necessary to check that the dependency update doesn't break the docs I think.

In any case it seems there is a configuration issue here with Firebase.

@mazzy89

Building the docs in CI definitely makes sense, and there is a step for it. What does not make sense for me is the deploy step.

mazzy89 · 2023-10-09T07:47:23Z

What does not make sense for me is the deploy step.

It builds a preview in a staging Firebase of how it would look like the docs when changes are committed. I think it makes totally sense. We do this extensively in also other repositories and it helps UI engineers to see live changes rather locally. Maybe we should not do it for version bumps but only for actual changes to the docs contents, structure, etc...

julienrbrt · 2023-10-09T07:51:13Z

What does not make sense for me is the deploy step.

It builds a preview in a staging Firebase of how it would look like the docs when changes are committed. I think it makes totally sense. We do this extensively in also other repositories and it helps UI engineers to see live changes rather locally. Maybe we should not do it for version bumps but only for actual changes to the docs contents, structure, etc...

Ahh I see. Then indeed it makes sense! I thought it would directly deploy the docs to prod 😅. Thanks for the clarification.

mazzy89 · 2023-10-09T07:54:48Z

Speaking about the issue of the Deploy step, it seems that the secrets is not filled
https://github.com/ignite/cli/blob/88ffe6208f81e158b096f8aeb78b8778075c875b/.github/workflows/docs-deploy-preview.yml#L42C1-L43C1
The job complains with the error:

Error: Input required and not supplied: firebaseServiceAccount

Unfortunately I do not have privileges to check repositories secrets. So this require escalation to someone who can access them.

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2023-10-12T17:31:54Z

Visit the preview URL for this PR (updated for commit b763234):

https://igntservices-docs--pr3685-dependabot-npm-and-y-7xmbl86n.web.app

_{(expires Tue, 07 Nov 2023 09:51:14 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5}

dependabot bot requested review from ilgooz, jeronimoalbi and Pantani as code owners October 7, 2023 15:15

dependabot bot added the dependencies Pull requests that update a dependency file label Oct 7, 2023

dependabot bot requested a review from julienrbrt as a code owner October 7, 2023 15:15

dependabot bot added component:js Pull requests that update Javascript code skip-changelog Don't check changelog for new entries labels Oct 7, 2023

dependabot bot requested a review from Ehsan-saradar as a code owner October 7, 2023 15:15

github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs 📖 docs labels Oct 7, 2023

julienrbrt self-assigned this Oct 8, 2023

julienrbrt assigned mazzy89 and unassigned julienrbrt Oct 9, 2023

dependabot bot force-pushed the dependabot/npm_and_yarn/docs/postcss-8.4.31 branch from 2c55aad to 9d953e5 Compare October 10, 2023 07:21

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

6136a9b

Pantani added 5 commits October 13, 2023 15:55

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

1098033

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

12cbba6

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

74e275d

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

ea7d7c7

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

8b64211

Pantani added 2 commits October 25, 2023 00:39

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

f6504c9

Merge branch 'main' into dependabot/npm_and_yarn/docs/postcss-8.4.31

b763234

julienrbrt approved these changes Oct 31, 2023

View reviewed changes

julienrbrt merged commit 54bb6b4 into main Oct 31, 2023
26 checks passed

julienrbrt deleted the dependabot/npm_and_yarn/docs/postcss-8.4.31 branch October 31, 2023 23:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): bump postcss from 8.4.21 to 8.4.31 in /docs #3685

chore(deps): bump postcss from 8.4.21 to 8.4.31 in /docs #3685

dependabot bot commented on behalf of github Oct 7, 2023 •

edited

Loading

julienrbrt commented Oct 8, 2023

jeronimoalbi commented Oct 9, 2023

mazzy89 commented Oct 9, 2023 •

edited

Loading

julienrbrt commented Oct 9, 2023

mazzy89 commented Oct 9, 2023 •

edited

Loading

julienrbrt commented Oct 9, 2023 •

edited

Loading

mazzy89 commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

chore(deps): bump postcss from 8.4.21 to 8.4.31 in /docs #3685

chore(deps): bump postcss from 8.4.21 to 8.4.31 in /docs #3685

Conversation

dependabot bot commented on behalf of github Oct 7, 2023 • edited Loading

8.4.31

8.4.30

8.4.29

8.4.28

8.4.27

8.4.26

8.4.25

8.4.24

8.4.23

8.4.22

8.4.31

8.4.30

8.4.29

8.4.28

8.4.27

8.4.26

8.4.25

8.4.24

8.4.23

8.4.22

julienrbrt commented Oct 8, 2023

jeronimoalbi commented Oct 9, 2023

mazzy89 commented Oct 9, 2023 • edited Loading

julienrbrt commented Oct 9, 2023

mazzy89 commented Oct 9, 2023 • edited Loading

julienrbrt commented Oct 9, 2023 • edited Loading

mazzy89 commented Oct 9, 2023 • edited Loading

github-actions bot commented Oct 12, 2023 • edited Loading

dependabot bot commented on behalf of github Oct 7, 2023 •

edited

Loading

mazzy89 commented Oct 9, 2023 •

edited

Loading

mazzy89 commented Oct 9, 2023 •

edited

Loading

julienrbrt commented Oct 9, 2023 •

edited

Loading

mazzy89 commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading