Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename plugins config file to igniteapps #3669

Merged
merged 17 commits into from
Oct 4, 2023
Merged

refactor: rename plugins config file to igniteapps #3669

merged 17 commits into from
Oct 4, 2023

Conversation

jeronimoalbi
Copy link
Member

No description provided.

@jeronimoalbi jeronimoalbi added type:refactor component:extensions Related to Ignite Extensions. labels Sep 26, 2023
@jeronimoalbi jeronimoalbi self-assigned this Sep 26, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. type:internal labels Sep 26, 2023
@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Sep 26, 2023 •
edited
Loading

This PR would require a migration step in the docs that requires the user to:

  1. Rename the plugins: section in plugins.yml to apps: in the global and local blockchain app config files
  2. Rename $HOME/.ignite/plugins/plugins.yml to $HOME/.ignite/plugins/igniteapps.yml (global config)
  3. Rename $HOME/.ignite/plugins to $HOME/.ignite/apps
  4. Rename plugins.yml to igniteapps.yml in any blockchain app (local config)

If we decide to document it I can add it as part of this PR.

Alternatively we can use ignite doctor to automate the process, so the only required step to migrate to the new CLI version is to run the doctor command.

@jeronimoalbi jeronimoalbi mentioned this pull request Sep 26, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit b2196f3):

https://igntservices-docs--pr3669-refactor-plugins-con-bz85tb15.web.app

(expires Mon, 09 Oct 2023 12:46:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@jeronimoalbi jeronimoalbi marked this pull request as ready for review September 26, 2023 13:59
Pantani
Pantani previously approved these changes Sep 27, 2023
View reviewed changes
@jeronimoalbi jeronimoalbi mentioned this pull request Sep 27, 2023
Merged
@jeronimoalbi
Copy link
Member Author

I'm adding the plugin config migration to the doctor command within this PR

@jeronimoalbi jeronimoalbi marked this pull request as draft September 27, 2023 08:37
@jeronimoalbi jeronimoalbi force-pushed the refactor/plugins-config-file branch from 2e6197e to 919e72e Compare September 27, 2023 15:49
@jeronimoalbi jeronimoalbi marked this pull request as ready for review September 27, 2023 16:56
julienrbrt
julienrbrt reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why not everything is being renamed. Am I missing something?

Edit: I realize that this PR is only about the file renaming now 🤔

ignite/cmd/plugin_default_test.go Outdated Show resolved Hide resolved
ignite/config/plugins/config.go Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jeronimoalbi jeronimoalbi merged commit 35e7c7a into main Oct 4, 2023
29 checks passed
@jeronimoalbi jeronimoalbi deleted the refactor/plugins-config-file branch October 4, 2023 13:34
@salmad3 salmad3 mentioned this pull request Jul 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@Pantani Pantani Pantani approved these changes

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:extensions Related to Ignite Extensions. component:packages type:internal type:refactor type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeronimoalbi @Pantani @julienrbrt