Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change docs to use "apps" instead of "plugins" #3651

Merged
merged 7 commits into from
Sep 26, 2023
Merged

docs: change docs to use "apps" instead of "plugins" #3651

merged 7 commits into from
Sep 26, 2023

Conversation

jeronimoalbi
Copy link
Member

Resolves #3647

@jeronimoalbi jeronimoalbi added skip-changelog Don't check changelog for new entries component:extensions Related to Ignite Extensions. 📖 docs labels Sep 8, 2023
@jeronimoalbi jeronimoalbi self-assigned this Sep 8, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1302318):

https://igntservices-docs--pr3651-docs-ignite-apps-tf68c8g6.web.app

(expires Tue, 03 Oct 2023 07:46:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Sep 8, 2023 •
edited
Loading

If this PR is approved it would require a small refactor to the "CLI plugins API" to change the user facing API from ignite plugin add ... to ignite app install ....

The docs use the concept of Ignite Apps except in some parts that describe the plugin system, but it is explained that under the hood Ignite Apps are implemented using a plugin system based on Hashicorp's plugins. I think is the fastest approach, but we could also decide for a bigger refactor to change the code to also use the concept of app instead of plugin.

@jeronimoalbi jeronimoalbi marked this pull request as ready for review September 19, 2023 15:40
Pantani
Pantani previously approved these changes Sep 19, 2023
View reviewed changes
julienrbrt
julienrbrt approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Pantani Pantani mentioned this pull request Sep 25, 2023
Closed
@jeronimoalbi jeronimoalbi merged commit f2d9a5f into main Sep 26, 2023
8 of 24 checks passed
@jeronimoalbi jeronimoalbi deleted the docs/ignite-apps branch September 26, 2023 07:45
@salmad3 salmad3 mentioned this pull request Jul 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@Ehsan-saradar Ehsan-saradar Ehsan-saradar approved these changes

@Pantani Pantani Pantani left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:extensions Related to Ignite Extensions. skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Plugins" to "Ignite Apps"
4 participants
@jeronimoalbi @Pantani @Ehsan-saradar @julienrbrt