Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with Go import paths in ts-client generation #3618

Merged
merged 4 commits into from
Aug 9, 2023
Merged

fix: issue with Go import paths in ts-client generation #3618

merged 4 commits into from
Aug 9, 2023

Conversation

jeronimoalbi
Copy link
Member

No description provided.

@jeronimoalbi jeronimoalbi added type:bug Something isn't working component:ts-client labels Aug 8, 2023
@jeronimoalbi jeronimoalbi self-assigned this Aug 8, 2023
@jeronimoalbi
Copy link
Member Author

The change avoid import paths like:

import { Any } from "github.com/cosmos/cosmos-sdk/codec/types"

The issue can be replicated by generating the TS client ignite generate ts-client --clear-cache which will result in files having invalid imports, for example ts-client/ibc.core.channel.v1/types/cosmos/upgrade/v1beta1/upgrade.ts.

@jeronimoalbi jeronimoalbi marked this pull request as ready for review August 8, 2023 09:55
@jeronimoalbi jeronimoalbi merged commit e9e6ff4 into main Aug 9, 2023
@jeronimoalbi jeronimoalbi deleted the fix/ts-client-generation branch August 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates component:ts-client type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeronimoalbi @Pantani