Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add google analytics #3599

Merged
merged 40 commits into from
Dec 1, 2023
Merged

feat(cmd): add google analytics #3599

merged 40 commits into from
Dec 1, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jul 26, 2023 •
edited
Loading

close #3589

@Pantani Pantani self-assigned this Jul 26, 2023
@Pantani Pantani changed the title feat(cmd): add googla analytics feat(cmd): add google analytics Jul 26, 2023
@Pantani Pantani requested a review from jeronimoalbi August 28, 2023 11:41
@michelleellen
Copy link

@Pantani @jeronimoalbi what does adding Google Analytics mean for Ignite users?

@max-hontar max-hontar mentioned this pull request Oct 9, 2023
Merged
julienrbrt and others added 2 commits November 29, 2023 17:18
@julienrbrt
chore: small improvements gacli (#3789)
39ad038 
* chore: small improvements gacli

* duplicate
remove sensitive data
bf6f3c4
@Pantani Pantani marked this pull request as ready for review November 30, 2023 10:48
@Pantani Pantani requested a review from julienrbrt November 30, 2023 11:06
julienrbrt and others added 2 commits November 30, 2023 15:40
@julienrbrt
refactor: good default http client for ga (#3791)
c9e3b0f 
* refactor: good default http client

* use client

* ilker feedback

* lint
remove Pallinder/go-randomdata pkg
f30ba51
@Pantani Pantani requested a review from julienrbrt November 30, 2023 21:07
julienrbrt
julienrbrt previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LFG 🚀

ilgooz
ilgooz requested changes Dec 1, 2023
View reviewed changes
ignite/pkg/gacli/gacli.go Outdated Show resolved Hide resolved
ignite/cmd/ignite/analytics.go Outdated Show resolved Hide resolved
ignite/cmd/ignite/analytics.go Outdated Show resolved Hide resolved
@Pantani Pantani requested review from ilgooz and julienrbrt December 1, 2023 11:21
julienrbrt
julienrbrt previously approved these changes Dec 1, 2023
View reviewed changes
ignite/cmd/ignite/analytics.go Outdated Show resolved Hide resolved
@Pantani Pantani requested a review from julienrbrt December 1, 2023 11:46
@ilgooz ilgooz merged commit c7cc3a5 into main Dec 1, 2023
12 of 25 checks passed
@ilgooz ilgooz deleted the feat/ga-analytics branch December 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz ilgooz approved these changes

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add analytics for the installer
5 participants
@Pantani @michelleellen @jeronimoalbi @ilgooz @julienrbrt