Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Cosmos SDK app compatibility check #3523

Merged
merged 11 commits into from
Jun 5, 2023

Conversation

jeronimoalbi
Copy link
Member

Resolves #3515

@jeronimoalbi jeronimoalbi requested review from Pantani and ilgooz May 30, 2023 18:12
@jeronimoalbi jeronimoalbi self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3523 (81efe32) into main (728e82d) will decrease coverage by 0.01%.
The diff coverage is 10.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
- Coverage   23.99%   23.99%   -0.01%     
==========================================
  Files         295      295              
  Lines       23747    23753       +6     
==========================================
  Hits         5699     5699              
- Misses      17539    17544       +5     
- Partials      509      510       +1     
Impacted Files Coverage Δ
ignite/cmd/chain_build.go 0.00% <0.00%> (ø)
ignite/cmd/chain_init.go 0.00% <0.00%> (ø)
ignite/cmd/chain_serve.go 0.00% <0.00%> (ø)
ignite/cmd/generate_go.go 0.00% <0.00%> (ø)
ignite/pkg/cosmosgen/generate.go 0.00% <0.00%> (ø)
ignite/pkg/cosmosver/cosmosver.go 40.90% <ø> (ø)
ignite/services/chain/chain.go 6.04% <0.00%> (-0.18%) ⬇️
ignite/services/scaffolder/scaffolder.go 0.00% <0.00%> (ø)
ignite/version/version.go 0.00% <0.00%> (ø)
ignite/pkg/cosmosanalysis/cosmosanalysis.go 85.96% <100.00%> (ø)
... and 1 more

@jeronimoalbi jeronimoalbi marked this pull request as ready for review May 31, 2023 08:31
@Pantani
Copy link
Collaborator

Pantani commented May 31, 2023

Screenshot 2023-05-31 at 15 13 37

For some reason, the error message was sometimes sliced. Maybe we should add a broken line, and also, we can add a message if the user doesn't want the upgrade the chain, he can use an older version of the CLI

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented May 31, 2023

Screenshot 2023-05-31 at 15 13 37 For some reason, the error message was sometimes sliced. Maybe we should add a broken line, and also, we can add a message if the user doesn't want the upgrade the chain, he can use an older version of the CLI

I tried locally multiple times and I don't see the issue but neither can we be sure it's related to a local setup issue. I would leave it as it is for now and reformat it if the problem reappears.

@ilgooz ilgooz merged commit bc3a1db into main Jun 5, 2023
@ilgooz ilgooz deleted the fix/introduce-cosmos-sdk-version-validation branch June 5, 2023 14:51
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* refactor: unify cosmos module path constant

* chore: add new COmos SDK versions to `comosover` pkg

* refactor: add assert for min supported Cosmos SDK version

* refactor: change scaffolder to assert minimum supported SDK version

* fix: correct SDK version error message

The format was improved for better readability and the warning icon
removed because it was not rendered properly.

* chore: add changelog entry

* fix: correct error string to pass CI

* feat: add chain option to check for supported Cosmos SDK version

* chore: change variable name for error message constant

* chore: correct error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backwards compatibility with v0.26.1
3 participants