Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(plugin): disable ignite network #3447

Closed
wants to merge 4 commits into from
Closed

chore(plugin): disable ignite network #3447

wants to merge 4 commits into from

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 2, 2023

Description

Disable ignite network since the servers are not working anymore

@Pantani Pantani requested a review from jeronimoalbi as a code owner March 2, 2023 07:51
@Pantani Pantani self-assigned this Mar 2, 2023
@Pantani Pantani requested a review from tbruyelle as a code owner March 2, 2023 07:51
Cplus360
Cplus360 previously approved these changes Mar 2, 2023
View reviewed changes
@jeronimoalbi
Copy link
Member

We should provably skip the TestEnsureDefaultPlugins test, comment or remove it

@ilgooz
Copy link
Member

ilgooz commented Mar 7, 2023

I think we can keep this enabled, let's discuss on our next call.

@ilgooz ilgooz marked this pull request as draft March 7, 2023 09:59
@tbruyelle
Copy link
Contributor

I suggest also to comment integration/network tests as mentioned in #3381.

@ilgooz ilgooz closed this Mar 17, 2023
@ilgooz ilgooz deleted the chore/disable-network branch March 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@Cplus360 Cplus360 Cplus360 left review comments

@tbruyelle tbruyelle Awaiting requested review from tbruyelle

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz will be requested when the pull request is marked ready for review ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 will be requested when the pull request is marked ready for review salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev will be requested when the pull request is marked ready for review toschdev is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt will be requested when the pull request is marked ready for review julienrbrt is a code owner

Assignees

@Pantani Pantani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pantani @jeronimoalbi @ilgooz @tbruyelle @Cplus360