Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmosclient): add gas adjustment flag #3446

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 2, 2023

close #3443

Description

Add gas-addjustment flag to the cosmos client

@Pantani Pantani requested a review from jeronimoalbi as a code owner March 2, 2023 07:30
@Pantani Pantani self-assigned this Mar 2, 2023
@Pantani Pantani requested a review from tbruyelle as a code owner March 2, 2023 07:30
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #3446 (c2589b1) into main (571eb43) will increase coverage by 0.01%.
The diff coverage is 46.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
+ Coverage   23.45%   23.46%   +0.01%     
==========================================
  Files         298      298              
  Lines       23510    23525      +15     
==========================================
+ Hits         5514     5521       +7     
- Misses      17499    17507       +8     
  Partials      497      497              
Impacted Files Coverage Δ
ignite/cmd/node.go 0.00% <0.00%> (ø)
ignite/cmd/node_tx.go 0.00% <0.00%> (ø)
ignite/pkg/cosmosclient/cosmosclient.go 72.31% <100.00%> (+0.42%) ⬆️

Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@ilgooz ilgooz merged commit 0323e4c into main Mar 4, 2023
@ilgooz ilgooz deleted the feat/client-add-gas-adjustment branch March 4, 2023 11:43
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* add gas adjustment to the cosmos client

* add changelog

* fix wrong changelog

* fix unit tests

* remove an unused `fmt.Sprintf`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go client "--gas-adjustment=1.15" option
2 participants