-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Shared Plugin RPC Host #3238
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
==========================================
+ Coverage 19.90% 20.06% +0.16%
==========================================
Files 384 385 +1
Lines 31003 31102 +99
==========================================
+ Hits 6170 6240 +70
- Misses 24245 24264 +19
- Partials 588 598 +10
|
@joshLong145 I refactored a little bit the cache part :
See b8fea7d Tell me if it's OK for you, if yes I will approve the PR 👍 I also made the cache functions private 66e9463 |
@tbruyelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature @joshLong145 , will be useful for sure !
* start to plugin host impl wip * comments * minor bug updates * updates per plugin config migration * small updates to sharedHost plugin option * update to isolate plugin cache * rename of utils to cache * print line removing * tidy * removing print out * additional comments * shared host load test * addition of caching tests for plugins * fmt * changelog * additional plugin cache tests * update shared host tests * review comments * addition cache test cases * fix typo * fix comment * update plugin `KillClient` for shared hosts * changelog update * fix test by omitting SharedHost from the yml when its false * update: migration of `sharedHost` flag to plugin manifest * scaffolding and plugin host check changes * update tests * format and lint * update plugin cache test * update property comment * update plugin cache to use full plugin path * cleanup of plugin tests * lint * update plugin sharedHost tests * update to plugin docs for `Sharedhost` flag * test: fix TestPluginLoadSharedHost * refac: plugin cach * Update docs/docs/contributing/01-plugins.md * refac: plugin cache func should be private * test: improve plugin kill assertions Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]>
Note: If the flag is not set no plugins will share a rpc server, keeping a 1 - 1 relationship between rpc client and server.
pkg/cache
to keep plugin host contexts for finding rpc servers in separate ignite processes.