Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change config upgrade to avoid an empty config file on error #3149

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix: change config upgrade to avoid an empty config file on error #3149

merged 2 commits into from
Nov 22, 2022

Conversation

jeronimoalbi
Copy link
Member

Fixes #3098

@jeronimoalbi jeronimoalbi added the type:bug Something isn't working label Nov 22, 2022
@jeronimoalbi jeronimoalbi self-assigned this Nov 22, 2022
@aljo242 aljo242 merged commit 237cc1b into main Nov 22, 2022
@aljo242 aljo242 deleted the fix/config-upgrade-revert-on-failure branch November 22, 2022 14:15
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@jeronimoalbi
fix: change config upgrade to avoid an empty config file on error (ig…
bfc4ee7 
…nite#3149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@jeronimoalbi jeronimoalbi

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config.yml upgrade erases the file when fails
3 participants
@jeronimoalbi @tbruyelle @aljo242