Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change generate commands to print paths of the generated code #2957

Merged
merged 11 commits into from
Oct 21, 2022
Merged

feat: change generate commands to print paths of the generated code #2957

merged 11 commits into from
Oct 21, 2022

Conversation

jeronimoalbi
Copy link
Member

Changes generate commands to print the paths to the generated code:

generate-vuex

@jeronimoalbi jeronimoalbi added the type:feat To implement new feature. label Oct 20, 2022
@jeronimoalbi jeronimoalbi self-assigned this Oct 20, 2022
@jeronimoalbi jeronimoalbi requested a review from fadeev as a code owner October 20, 2022 08:25
tbruyelle
tbruyelle previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 minor things :

  • g openapi prints the relative path while the other prints the absolute path
  • g dart is broken so I couldn't test it.

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Oct 20, 2022 •
edited
Loading

LGTM, just 2 minor things :

  • g openapi prints the relative path while the other print the absolute path
  • g dart is broken so I couldn't test it.

@tbruyelle thats is correct, I am working on a PR for that. It was originally part of this one but I decided to make it in another one because it will support absolute config paths.

Update: PR for absolute client config paths #2958

tbruyelle
tbruyelle previously approved these changes Oct 20, 2022
View reviewed changes
aljo242
aljo242 reviewed Oct 21, 2022
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@aljo242 aljo242 merged commit b81dff0 into develop Oct 21, 2022
@aljo242 aljo242 deleted the feat/improve-generate-commands-feedback branch October 21, 2022 20:54
@jeronimoalbi jeronimoalbi mentioned this pull request Oct 24, 2022
Merged
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@jeronimoalbi @tbruyelle
feat: change generate commands to print paths of the generated code (i…
726cf80 
…gnite#2957)

* feat: change generate commands to print paths of the generated code

* fix: remove redefinition of variable

Co-authored-by: Thomas Bruyelle <[email protected]>

* chore: update changelog

* chore: update changelog

Co-authored-by: Thomas Bruyelle <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@jeronimoalbi jeronimoalbi

Labels
type:feat To implement new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeronimoalbi @tbruyelle @aljo242