-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dependencies option for module create #1287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
reviewed
Jun 25, 2021
fadeev
previously approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ilgooz
requested changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! 🍰
Co-authored-by: İlker G. Öztürk <[email protected]>
ilgooz
requested changes
Jun 29, 2021
ilgooz
reviewed
Jul 1, 2021
ilgooz
previously approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
fadeev
previously approved these changes
Jul 5, 2021
ilgooz
approved these changes
Jul 5, 2021
fadeev
approved these changes
Jul 5, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Co-authored-by: İlker G. Öztürk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--dep
option for themodule create
command. This option allows to provide a comma-separated list of module name that will be dependencies of the module to scaffold.expected_keepers.go
with interfaces will be created as the current standard with Cosmos SDKThe scaffolder will add the keeper instance in
app.go
with the formapp.[DependencyName]Keeper
if this value is not present inapp.go
we will have the same behavior as when there is a missing placeholder inapp.go
:app.go
will be left untouched but the module will still be scaffolded.The module will then not be registered in
app.go
but it will be scaffolded with the dependencies in its keeperSmall issue with previously scaffolded app if using
gov
dependency: #818 (comment)One way to test:
Then add
AppendFoo(ctx sdk.Context, foo types.Foo) uint64
inexpected_keepers.go
inhehe/keeper
Then add
k.hahaKeeper.AppendFoo(ctx, hahamoduletypes.Foo{Bar:msg.Bar})
in the handler of thecreate-foo
message ofhehe
Finally, strings can be added from module
hehe
venusd tx hehe create-foo hello --from alice
into the list of thehaha
modulevenusd q haha list-foo