Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running ignite c serve -r removes generated Vuex stores for 3rd party modules #2986

Closed
jeronimoalbi opened this issue Oct 24, 2022 · 1 comment · Fixed by #2997
Closed

Running ignite c serve -r removes generated Vuex stores for 3rd party modules #2986

jeronimoalbi opened this issue Oct 24, 2022 · 1 comment · Fixed by #2997
Assignees
Labels
component:cli-serve Related to Ignite serve. type:refactor

Comments

@jeronimoalbi
Copy link
Member

Description

Generated Vuex stores for 3rd party modules are removed from the vue/src/store/generated/index.ts file when the blockchain app is served using the --force-reset flag without --proto-all-modules.

This might be an issue when users generated Vuex code before running the blockchain app resetting the state in which case the generated store directories won't be removed but the index.ts file won't include them leading to an "inconsistent" code.

New users might not be aware of this behaviour. Maybe we should consider to always generate Vuex code for all modules by default.

@fadeev
Copy link
Contributor

fadeev commented Oct 25, 2022

Maybe we should consider to always generate Vuex code for all modules by default.

Yes, please. The reason this was not the default behavior is that TS code generation happens on ignite c serve and it takes much longer to generate clients both for standard and custom module.

Hence, my proposal to not generate anything (except proto) when running serve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli-serve Related to Ignite serve. type:refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants