Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate TS/Vue clients when scaffolding #2838

Closed
Tracked by #3051
fadeev opened this issue Sep 17, 2022 · 1 comment · Fixed by #2997
Closed
Tracked by #3051

Don't generate TS/Vue clients when scaffolding #2838

fadeev opened this issue Sep 17, 2022 · 1 comment · Fixed by #2997
Assignees
Labels
component:design Design or UX improvements component:scaffold Feature, enhancement, or refactor related to scaffolding. component:ts-client

Comments

@fadeev
Copy link
Contributor

fadeev commented Sep 17, 2022

Currently, Ignite generates TS/Vue clients both when scaffolding list/map/etc and serving a chain.

Originally, that made sense, because we scaffolded forms in the Vue template and needed the chain to be in sync with the template. This is not a bad thing in itself, but I don't think this is no longer required.

I propose we decouple scaffolding from code generation. When a chain is first scaffolded, we still have the template and TS/Vue clients required for it to function properly. However, we no longer do code gen when serving and scaffolding. It's not hard to run ignite g ts-client whenever you need a client to be regenerated.

@fadeev fadeev added proposal codegen component:scaffold Feature, enhancement, or refactor related to scaffolding. labels Sep 17, 2022
@0xZXDX
Copy link

0xZXDX commented Sep 24, 2022

agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:design Design or UX improvements component:scaffold Feature, enhancement, or refactor related to scaffolding. component:ts-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants