Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slideshow template #608

Merged
merged 1 commit into from
Jan 8, 2020
Merged

feat: Add slideshow template #608

merged 1 commit into from
Jan 8, 2020

Conversation

RakeshUP
Copy link
Member

@RakeshUP RakeshUP commented Jan 4, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Template addition

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    A new template slideshow is available

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Closes Create presentations with idyll #559

@RakeshUP
Copy link
Member Author

RakeshUP commented Jan 4, 2020

@mathisonian, I have removed Vega Lite component because it doesn't seem to resize for smaller device sizes.
Is it good enough?

@RakeshUP RakeshUP requested a review from mathisonian January 4, 2020 11:49
Copy link
Member

@mathisonian mathisonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested out locally - looks and works great! 🎉

I think its fine to leave out VL and have people install that themselves. Although I think the latest release is supposed to have some responsive feature, I haven't looked into this yet.

@mathisonian mathisonian merged commit 7b9c1c5 into idyll-lang:master Jan 8, 2020
@mathisonian
Copy link
Member

/cc @ZeningQu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create presentations with idyll
2 participants