-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add citation and references #575
Add citation and references #575
Conversation
This looks great @rollaball! One use case this doesn't quite cover yet is a way to cite via an id. For example it is common to cite the same work multiple times, it would be nice if there were a way to provide a shortcut if you want to reference something again, without typing in all the information. Can you think of a clean way to do that? |
@mathisonian does this seem like a good way to do this? |
That works for me! Only comment is that We should probably print a warning if you provide a I like this API because it doesn't seem like it would need any changes if we also add bibtex support in the future. |
Nice! I agree Other examples:
|
It should probably accept a |
Thanks for the links @fredhohman! @rollaball would calling it |
@mathisonian |
@mathisonian |
@rollaball let's go with |
Hey, @mathisonian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested locally and everything seems to work great, thanks @rollaball! I've just left a couple small update requests and then I'm good to merge 👍 .
Updates look great - thanks @rollaball 🎉 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds Components for Citation and References.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Add [Cite/] anywhere on the page with props authors, title and source.
Then Add [Cite.References /] and it will get the list of all citations on the page
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Issue: Add reference component #509