-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Add Idyll clean option #540
feat : Add Idyll clean option #540
Conversation
Thanks @amitbadala! This is looking good. One thing I'd want to add before merging: The idyll folder can contain a secret token that is used to deploy projects to https://idyll.pub. I think this command should check for the existence of such a file ( "This command will remove the idyll cache folder, including your idyll.pub token. Subsequent deploys to idyll.pub will receive a new URL. Are you sure you wish to continue?" |
334c305
to
5bcd33e
Compare
5bcd33e
to
8f23ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small nitpick, otherwise looks good to go! I'll merge once that final tweak is made
@amitbadala can you please avoid force pushing to PRs? You can push commits as you work and I'll squash them during the merge if necessary. |
my bad !.. would ensure that it's not repeated |
Looking great, thanks @amitbadala |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature update.
What is the current behavior? (You can also link to an open issue here)
Addresses
idyll clean
#533What is the new behavior (if this is a feature change)?
Idyll clean
option can be used to remove .idyll folderDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information: