Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Add Idyll clean option #540

Merged

Conversation

amitbadala
Copy link
Member

@amitbadala amitbadala commented Jun 26, 2019

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature update.

  • What is the current behavior? (You can also link to an open issue here)
    Addresses idyll clean #533

  • What is the new behavior (if this is a feature change)?
    Idyll clean option can be used to remove .idyll folder

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

  • Other information:

@amitbadala
Copy link
Member Author

idyll-clean

@mathisonian
Copy link
Member

Thanks @amitbadala! This is looking good. One thing I'd want to add before merging:

The idyll folder can contain a secret token that is used to deploy projects to https://idyll.pub. I think this command should check for the existence of such a file (.idyll/token) and if it exists show a warning message along the lines of

"This command will remove the idyll cache folder, including your idyll.pub token. Subsequent deploys to idyll.pub will receive a new URL. Are you sure you wish to continue?"

@amitbadala amitbadala force-pushed the amitbadala/add-idyll-clean-option branch from 334c305 to 5bcd33e Compare June 29, 2019 09:42
@amitbadala
Copy link
Member Author

idyll-clean gif

@amitbadala amitbadala requested a review from mathisonian June 29, 2019 09:51
@amitbadala amitbadala force-pushed the amitbadala/add-idyll-clean-option branch from 5bcd33e to 8f23ea1 Compare June 29, 2019 13:16
Copy link
Member

@mathisonian mathisonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small nitpick, otherwise looks good to go! I'll merge once that final tweak is made

packages/idyll-cli/bin/cmds/clean.js Outdated Show resolved Hide resolved
@mathisonian
Copy link
Member

@amitbadala can you please avoid force pushing to PRs? You can push commits as you work and I'll squash them during the merge if necessary.

@amitbadala
Copy link
Member Author

amitbadala commented Jul 2, 2019

@amitbadala can you please avoid force pushing to PRs? You can push commits as you work and I'll squash them during the merge if necessary

my bad !.. would ensure that it's not repeated

@amitbadala amitbadala self-assigned this Jul 4, 2019
@mathisonian mathisonian merged commit e4c8cbe into idyll-lang:master Jul 6, 2019
@mathisonian
Copy link
Member

Looking great, thanks @amitbadala

@amitbadala amitbadala deleted the amitbadala/add-idyll-clean-option branch July 7, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants