-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ new ] Quantity for proof in with-clauses #3415
Open
spcfox
wants to merge
5
commits into
idris-lang:main
Choose a base branch
from
spcfox:with-proof-multiplicity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spcfox
force-pushed
the
with-proof-multiplicity
branch
from
November 18, 2024 13:18
c407589
to
ba57b5b
Compare
spcfox
commented
Nov 28, 2024
spcfox
force-pushed
the
with-proof-multiplicity
branch
from
December 4, 2024 11:30
ba57b5b
to
980ef1b
Compare
spcfox
added a commit
to spcfox/idris2-elab-util
that referenced
this pull request
Dec 4, 2024
spcfox
added a commit
to spcfox/idris2-lsp
that referenced
this pull request
Dec 4, 2024
This PR is ready to review. |
spcfox
force-pushed
the
with-proof-multiplicity
branch
from
December 9, 2024 12:37
8731e10
to
eda38fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the quantity of proof in with-clause is the same as the quantity of expression. But often proofs are needed only at compile time. Example:
So I suggest adding the ability to separately specify quantities for proofs.
Note that
prf
is currently erased in the following code, but in this version it will now be unrestricted, as will all variables for which multiplicity is not explicitly specified. This may affect existing code and probably requires discussion.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md
(and potentially alsoCONTRIBUTORS.md
).