Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto detection for dark browser/system mode #237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add auto detection for dark browser/system mode #237

wants to merge 2 commits into from

Conversation

rugk
Copy link
Contributor

@rugk rugk commented May 16, 2019 •
edited
Loading

via "prefers-color-scheme".

Fixes #236

(Only tested JS changes locally in browser.)

Testable with:

avindra
avindra approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@avindra avindra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change.

Should rebase the PR to cleanup the git conflict and hopefully @idank can merge after.

explainshell/web/static/js/es.js Show resolved Hide resolved
@idank
Copy link
Owner

idank commented Dec 27, 2020

Can someone please fix the conflicts?

@rugk
Copy link
Contributor Author

rugk commented Dec 31, 2020

Done, as far as I could do this out of my head.

@mundanevision20 mundanevision20 mentioned this pull request Sep 21, 2024
Open
@rugk
Copy link
Contributor Author

rugk commented Sep 23, 2024 •
edited
Loading

Anything else to change here though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avindra avindra avindra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to dark mode automatically via prefers-color-scheme
3 participants
@rugk @idank @avindra