Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all error constructors #313

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

ccamel
Copy link
Contributor

@ccamel ccamel commented Jan 18, 2024

This PR tackles issue #310.

I propose to make all error types public, similar to how domain_error and others were previously made accessible. Given our project's significant reliance on ichiban/prolog, having access to the entire spectrum of error types used by the library would be highly beneficial for us as developers.

This means making these error constructors available for everyone: existence_error, permission_error, representation_error, resource_error, syntax_error, and evaluation_error.

Thanks.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c682cd3) 99.21% compared to head (11c4f43) 99.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          23       23           
  Lines        7272     7283   +11     
=======================================
+ Hits         7215     7226   +11     
  Misses         51       51           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ichiban ichiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the high quality PR! I have a couple of minor change proposals.

engine/exception.go Outdated Show resolved Hide resolved
engine/exception.go Outdated Show resolved Hide resolved
@ccamel ccamel force-pushed the feat/expose-exception branch from 1307bcc to 3687712 Compare February 14, 2024 16:22
This includes: existence_error, permission_error, representation_error,
resource_error,  syntax_error, and evaluation_error.
@ccamel ccamel force-pushed the feat/expose-exception branch from 3687712 to 11c4f43 Compare February 14, 2024 16:24
@ccamel
Copy link
Contributor Author

ccamel commented Feb 14, 2024

@ichiban Thanks for the code review and your insightful comments. Much appreciated. I've made the updates.

@ccamel ccamel requested a review from ichiban February 14, 2024 16:28
@ichiban ichiban merged commit 235fea6 into ichiban:main Feb 18, 2024
3 checks passed
@ccamel ccamel deleted the feat/expose-exception branch February 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants