Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for KeepSession #274

Closed
jay-mack opened this issue Dec 14, 2022 · 1 comment · Fixed by #292
Closed

Refactor for KeepSession #274

jay-mack opened this issue Dec 14, 2022 · 1 comment · Fixed by #292
Labels
enhancement released

Comments

@jay-mack
Copy link
Contributor

In version 0.6.0, passport triggers a session regeneration (v5 vs v6), this is triggered automatically. The way the SDK is currently written, there is no way for the end user to pass KeepSession: true to this regeneration function.
A fix was implemented so the SDK passes the "keepSessionInfo" so this merge occurs.

This needs to be refactored so that the user can pass this param instead.
abod-akhras pushed a commit that referenced this issue Jan 31, 2023
fix(webapp-strategy.js): fix the SDK to work with Passport version 6.0.0
98a8440 
>>>> LONGER Description goes here

BREAKING CHANGE: KeepSessionInfo should be passed like { keepSessionInfo: true }

fix #274 & fix #287
@abod-akhras abod-akhras mentioned this issue Jan 31, 2023
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
1 participant
@jay-mack