Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllint is now installed by default on GitHub actions virtual environments #10

Closed
yvele opened this issue Aug 18, 2020 · 5 comments · Fixed by #11
Closed

yamllint is now installed by default on GitHub actions virtual environments #10

yvele opened this issue Aug 18, 2020 · 5 comments · Fixed by #11

Comments

@yvele
Copy link

yvele commented Aug 18, 2020

See actions/runner-images#1142 (comment)

and adrienverge/yamllint#300

You probably don't need a custom Docket image anymore as yamllint already is installed by default 🤷

@ibiqlik
Copy link
Owner

ibiqlik commented Aug 24, 2020

@yvele NICE, I'll check it soon. If all is good, this action could potentially be converted to composite action and basically just serve as command line builder for running yamllint. On other hand docker image is good for use in self-hosted runners (though, one could argue that it's easier to preinstall software on self-hosted runners than GitHub provided ones)

ibiqlik added a commit that referenced this issue Aug 25, 2020
@ibiqlik
Copy link
Owner

ibiqlik commented Aug 25, 2020

Doh, the version deployed is 1.10.0 which is a bit old and doesn't support some options, like -format and looks like it doesn't read .yamllint config by default. Investigation continues ...

@ibiqlik
Copy link
Owner

ibiqlik commented Nov 2, 2020

I think it is too unpredictable and somewhat disruptive to use pre-installed (outdated) yamllint. I'll create a composite branch have the action use pre-installed yamllint but not include in release, at least not yet.

@ibiqlik ibiqlik closed this as completed Nov 2, 2020
@yvele
Copy link
Author

yvele commented Nov 2, 2020

Hey @ibiqlik it's fixed directly within GitHub Actions see actions/runner-images#1657 (comment) and now install the lastest yamllint version 😉

@ibiqlik ibiqlik reopened this Nov 3, 2020
@ibiqlik
Copy link
Owner

ibiqlik commented Nov 3, 2020

That's great news @yvele. I'm reopening the issue and will give it another take at composite action.

ibiqlik added a commit that referenced this issue Nov 8, 2020
@ibiqlik ibiqlik linked a pull request Nov 8, 2020 that will close this issue
ibiqlik added a commit that referenced this issue Nov 8, 2020
ibiqlik added a commit that referenced this issue Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants