Increase top margin for iPhone X #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelQ
reviewed
Nov 6, 2017
| @@ -9,7 +9,7 @@ import App.Font as Font | |||
| import Message exposing (..) | |||
| import ScrollableTabView exposing (..) | |||
| import Model exposing (Model) | |||
|
|
|||
| import Hacks.IPhoneX exposing(isIPhoneX) | |||
| matchesIPhoneXDimensions : Bool | ||
| matchesIPhoneXDimensions = | ||
| let | ||
| iPhoneXHeight = 812 |
There was a problem hiding this comment.
Worth extracting to its own constant function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The To/From direction tabs looked scrunched up against the notch on the iPhone X. This uses a hacky way to check if the current running device is an iPhone X (based on screen dimensions), and adds 20 points of additional margin if so.
Before:
After: