Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm-ify the push notifications code #71

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Elm-ify the push notifications code #71

wants to merge 21 commits into from

Conversation

iancanderson
Copy link
Owner

This removes the JS code that currently backs push notifications in favor of using the Alert and PushNotificationIOS modules that I'm working on contributing to elm-native-ui: ohanhi/elm-native-ui@master...thoughtbot:ia-push-notifications-ios

The behavior should be the same as before:

  • If we've never pre-prompted a user about push notifications, show them a pre-prompt dialog
  • If they accept, show them the system permissions dialog
  • If they accept that, record their device token in AsyncStorage
  • If they already have a stop selected:
    • Upsert their installation record on the backend so we can send a push notification to the device in the future
  • If they don't have a stop selected, we wait until they select a stop to upsert their installation record

@iancanderson
Script to symlink to local elm-native-ui
9e0eec0
@iancanderson
WIP
e315a60
@iancanderson
Refactor to use actual types for DeviceToken and Stop
382f7ea
@iancanderson
Check settings to see if already prompted
32c6db1
@iancanderson
Show pre-prompt dialog for push notifications
7c6789c
@iancanderson
Use record for alert button
da79361
@iancanderson
Show OS dialog for push permissions
f4534df
@iancanderson
Rename import
ac2adc9
@iancanderson
Remove unnecessary parameter
81cbca3
@iancanderson
Use prompted key
f867faf
@iancanderson
Watch nested elm files when running npm run watch
d28ce3f
@iancanderson
Record the fact that we prompted the user
a79f69e
@iancanderson
Rename
9b53142
@iancanderson
Use string instead of custom error type
5b90689
@iancanderson
Remove JS push notification code
41f9544
@iancanderson
Bump iOS to 1.6.1, build 23
cf3f080
@iancanderson
Fix build archiving in XCode
3005113 
See
facebook/react-native#12042 (comment)

- Adds React project as a target in our Release scheme
- De-parallelizes the build
@iancanderson
Fix debug build
6b38e53
@iancanderson
Bump iOS build
c911015
@iancanderson
Use String instead of custom type for alert error
ec2b179
@iancanderson
Bump iOS build to 25
759ce1b
@iancanderson iancanderson mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iancanderson