-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uk (Ukrainian) locale month #899
Conversation
Codecov Report
Continue to review full report at Codecov.
|
Please fix the unit test. |
@iamkun done |
import uk from '../../src/locale/uk' | ||
import '../../src/locale/zh-cn' | ||
|
||
dayjs.extend(customParseFormat) | ||
dayjs.extend(localizedFormat) | ||
dayjs.extend(localeData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, just removed
src/locale/uk.js
Outdated
const monthFormat = 'січня_лютого_березня_квітня_травня_червня_липня_серпня_вересня_жовтня_листопада_грудня'.split('_') | ||
const monthStandalone = 'січень_лютий_березень_квітень_травень_червень_липень_серпень_вересень_жовтень_листопад_грудень'.split('_') | ||
|
||
const monthShortFormat = 'сiч_лют_бер_квiт_трав_черв_лип_серп_вер_жовт_лист_груд'.split('_') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no difference in monthShort
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the original monthsShort
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the same logic with long names
(I looked Russian locale file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need actually.
You can just add monthFormat
and monthStandalone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
there's one lint error. 46:15 error Missing space before value for key 'monthsShort' |
Thanks |
🎉 This PR is included in version 1.8.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.8.28](iamkun/dayjs@v1.8.27...v1.8.28) (2020-05-28) ### Bug Fixes * Fix CustomParseFormat plugin month index error ([#918](iamkun/dayjs#918)) ([fa2ec7f](iamkun/dayjs@fa2ec7f)), closes [#915](iamkun/dayjs#915) * Update Ukrainian (uk) locale monthFormat and monthStandalone ([#899](iamkun/dayjs#899)) ([a08756e](iamkun/dayjs@a08756e))
## [1.8.28](iamkun/dayjs@v1.8.27...v1.8.28) (2020-05-28) ### Bug Fixes * Fix CustomParseFormat plugin month index error ([#918](iamkun/dayjs#918)) ([fa2ec7f](iamkun/dayjs@fa2ec7f)), closes [#915](iamkun/dayjs#915) * Update Ukrainian (uk) locale monthFormat and monthStandalone ([#899](iamkun/dayjs#899)) ([a08756e](iamkun/dayjs@a08756e))
## [1.8.28](iamkun/dayjs@v1.8.27...v1.8.28) (2020-05-28) ### Bug Fixes * Fix CustomParseFormat plugin month index error ([#918](iamkun/dayjs#918)) ([fa2ec7f](iamkun/dayjs@fa2ec7f)), closes [#915](iamkun/dayjs#915) * Update Ukrainian (uk) locale monthFormat and monthStandalone ([#899](iamkun/dayjs#899)) ([a08756e](iamkun/dayjs@a08756e))
Hi! Please, approve my pull request for uk (Ukrainian) locale. Thanks!