Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue#646 #649

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Fixes issue#646 #649

merged 2 commits into from
Jul 31, 2019

Conversation

g1eny0ung
Copy link
Contributor

@g1eny0ung g1eny0ung commented Jul 31, 2019

close #646

1. Add test:jest in package.json to test a single file conveniently.
@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #649 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #649   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       987    988    +1     
  Branches    143    144    +1     
===================================
+ Hits        987    988    +1
Impacted Files Coverage Δ
src/plugin/relativeTime/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1f15f...6ff01db. Read the comment docs.

package.json Outdated
@@ -8,6 +8,7 @@
"scripts": {
"test": "TZ=Pacific/Auckland npm run test-tz && TZ=Europe/London npm run test-tz && TZ=America/Whitehorse npm run test-tz && npm run test-tz && jest",
"test-tz": "date && jest test/timezone.test --coverage=false",
"test:jest": "jest",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding this?

@iamkun iamkun merged commit a385d5c into iamkun:dev Jul 31, 2019
@iamkun
Copy link
Owner

iamkun commented Aug 27, 2019

🎉 This PR is included in version 1.8.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromNow() gives inconsistent results between UTC & local mode
3 participants