Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create my.js #485

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Create my.js #485

merged 4 commits into from
Feb 11, 2019

Conversation

pete-arif
Copy link
Contributor

suggestion for Bahasa Melayu (Malaysia) locale

suggestion for Bahasa Melayu (Malaysia) locale
src/locale/my.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #485 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #485   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        57     58    +1     
  Lines       502    505    +3     
  Branches     81     81           
===================================
+ Hits        502    505    +3
Impacted Files Coverage Δ
src/locale/ms.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f251493...62a5b96. Read the comment docs.

Copy link
Contributor Author

@pete-arif pete-arif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name locale updated.

@iamkun
Copy link
Owner

iamkun commented Feb 11, 2019

Should this be ms instead of my? https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes

@iamkun
Copy link
Owner

iamkun commented Feb 11, 2019

and file name pls

@pete-arif
Copy link
Contributor Author

and file name pls
Should this be ms instead of my? https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes

It should be... apologies. 👍
(personally, not really agree to that ISO naming for the language, but standards is standards)

@pete-arif pete-arif closed this Feb 11, 2019
@pete-arif pete-arif reopened this Feb 11, 2019
@iamkun iamkun merged commit cb208b0 into iamkun:dev Feb 11, 2019
iamkun pushed a commit that referenced this pull request Feb 14, 2019
## [1.8.6](v1.8.5...v1.8.6) (2019-02-14)

### Bug Fixes

* Add Bahasa Melayu (Malaysia) locale ([#485](#485)) ([cb208b0](cb208b0))
* Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](a7e05e0))
* Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](9884ca5)), closes [#494](#494)
* Fix commonJS require ES Module bug in webpack4 ([23f9f3d](23f9f3d))
* Fix startOf week bug while week start is not Sunday ([5eaf77b](5eaf77b))
* Implemented isBetween inclusivity ([#464](#464)) ([af2f4f1](af2f4f1))
* Update Swedish and Finnish locales ([#488](#488)) ([f142082](f142082))
@iamkun
Copy link
Owner

iamkun commented Feb 14, 2019

🎉 This PR is included in version 1.8.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.6](iamkun/dayjs@v1.8.5...v1.8.6) (2019-02-14)

### Bug Fixes

* Add Bahasa Melayu (Malaysia) locale ([#485](iamkun/dayjs#485)) ([cb208b0](iamkun/dayjs@cb208b0))
* Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](iamkun/dayjs@a7e05e0))
* Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](iamkun/dayjs@9884ca5)), closes [#494](iamkun/dayjs#494)
* Fix commonJS require ES Module bug in webpack4 ([23f9f3d](iamkun/dayjs@23f9f3d))
* Fix startOf week bug while week start is not Sunday ([5eaf77b](iamkun/dayjs@5eaf77b))
* Implemented isBetween inclusivity ([#464](iamkun/dayjs#464)) ([af2f4f1](iamkun/dayjs@af2f4f1))
* Update Swedish and Finnish locales ([#488](iamkun/dayjs#488)) ([f142082](iamkun/dayjs@f142082))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.6](iamkun/dayjs@v1.8.5...v1.8.6) (2019-02-14)

### Bug Fixes

* Add Bahasa Melayu (Malaysia) locale ([#485](iamkun/dayjs#485)) ([cb208b0](iamkun/dayjs@cb208b0))
* Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](iamkun/dayjs@a7e05e0))
* Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](iamkun/dayjs@9884ca5)), closes [#494](iamkun/dayjs#494)
* Fix commonJS require ES Module bug in webpack4 ([23f9f3d](iamkun/dayjs@23f9f3d))
* Fix startOf week bug while week start is not Sunday ([5eaf77b](iamkun/dayjs@5eaf77b))
* Implemented isBetween inclusivity ([#464](iamkun/dayjs#464)) ([af2f4f1](iamkun/dayjs@af2f4f1))
* Update Swedish and Finnish locales ([#488](iamkun/dayjs#488)) ([f142082](iamkun/dayjs@f142082))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.8.6](iamkun/dayjs@v1.8.5...v1.8.6) (2019-02-14)

### Bug Fixes

* Add Bahasa Melayu (Malaysia) locale ([#485](iamkun/dayjs#485)) ([cb208b0](iamkun/dayjs@cb208b0))
* Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](iamkun/dayjs@a7e05e0))
* Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](iamkun/dayjs@9884ca5)), closes [#494](iamkun/dayjs#494)
* Fix commonJS require ES Module bug in webpack4 ([23f9f3d](iamkun/dayjs@23f9f3d))
* Fix startOf week bug while week start is not Sunday ([5eaf77b](iamkun/dayjs@5eaf77b))
* Implemented isBetween inclusivity ([#464](iamkun/dayjs#464)) ([af2f4f1](iamkun/dayjs@af2f4f1))
* Update Swedish and Finnish locales ([#488](iamkun/dayjs#488)) ([f142082](iamkun/dayjs@f142082))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants