refactor: move declaration for english 'ordinal' to 'en' locale file

[BePo65]

All locale files have a definition for 'ordinal' except the 'en' one. For this locale the definition of 'ordinal' is part of the 'AdvancedFormat' plugin. This is inconsistent not quite logical.

This pr solves this topic and should solve issue #1891

[codecov]

Codecov Report

Merging #2071 (74144ff) into dev (c9370ea) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #2071   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       182    +1     
  Lines         2080      2080           
  Branches       547       547           
=========================================
  Hits          2080      2080           

Impacted Files	Coverage Δ
src/locale/en.js	100.00% <100.00%> (ø)
src/plugin/advancedFormat/index.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[iamkun]

Thanks.

But there's another problem, format('Do') function is also added in advancedFormat plugin, that is to say, even if added ordinal to 'en', we still can't get correct format('Do') result without advancedFormat plugin 🤔

[BePo65]

Of course that is correct. But IMO code / architecture should be consistent.
By now we have the situation that for 'en' we have the definition of the ordinal function in the plugin AdvancedFormat and for all other locales we have it in the corresponding locale file.

If someone want to do format('Do'), he needs AdvancedFormat, so this does not make a functional difference, but architecture is more than pure functionality (I am sure you agree, if you look at my programs from 30 years ago 😄).

[iamkun]

well, that sounds reasonable, let's get it merged.

[iamkun]

🎉 This PR is included in version 1.11.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀