fix: export type of duration plugin

[CatsMiaow]

All plugins have the following format, but only the duration plugin is export default in types

dayjs/src/plugin/isMoment/index.js

Line 1 in f95ac15

export default (o, c, f) => {

dayjs/types/plugin/isMoment.d.ts

Line 4 in f95ac15

export = plugin

When dayjs is actually built, it doesn't export the default object, so typescript runtime error occurs on duration.default.
https://cdn.jsdelivr.net/npm/[email protected]/plugin/duration.js

This is a fix that keeps the same exports as other plugins.

[codecov]

Codecov Report

Merging #1094 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1094   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1547      1547           
  Branches       328       328           
=========================================
  Hits          1547      1547           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95ac15...2ee5abb. Read the comment docs.

[iamkun]

Thanks. But this would lead to a new issue, how can we get the Duration type?

// currently we could import the type like this
import { Duration } from 'dayjs/pulgin/duration'

[CatsMiaow]

PR fixed.
Referred to @types/mathjs

esModuleInterop: false

import * as duration from 'dayjs/plugin/duration';
dayjs.extend(duration);

const time: duration.Duration = dayjs.duration(1234, 's');
const [hour, minute, second] = [time.hours(), time.minutes(), time.seconds()];

esModuleInterop: true

import duration, { Duration } from 'dayjs/plugin/duration';
dayjs.extend(duration);

const time: Duration = dayjs.duration(1234, 's');
const [hour, minute, second] = [time.hours(), time.minutes(), time.seconds()];

[iamkun]

Cool

[iamkun]

One small question, can we still use class Duration here, or is it necessary?

[CatsMiaow]

An error occurred when using a class in a namespace, so the class was implemented as an interface.
It probably conflicts with the const plugin object. https://stackoverflow.com/a/51716899

[iamkun]

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀