Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix LocaleData plugin to support instance.weekdays() API #1019

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Aug 21, 2020

fix #1017

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1019 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1019   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          171       171           
  Lines         1487      1488    +1     
  Branches       314       315    +1     
=========================================
+ Hits          1487      1488    +1     
Impacted Files Coverage Δ
src/plugin/localeData/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1890c9...da51865. Read the comment docs.

@iamkun iamkun merged commit a09d259 into dev Aug 22, 2020
iamkun pushed a commit that referenced this pull request Sep 2, 2020
## [1.8.35](v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](#1023)) ([40ab6d9](40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](#1019)) ([a09d259](a09d259)), closes [#1017](#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](1533a2c))
@iamkun
Copy link
Owner Author

iamkun commented Sep 2, 2020

🎉 This PR is included in version 1.8.35 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Sep 2, 2020
@iamkun iamkun deleted the fix/plugin-localData branch September 28, 2020 02:28
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocaleData: weekdays is not a function on instance level
1 participant