-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] support utcOffset("+08:00") #1085
Comments
Yes, number in seconds and minutes are supported at the moment. |
Any demo of using string, please? |
例如:utcOffset("+08:00"),参考地址:https://momentjs.com/docs/#/manipulating/utc-offset/ 现在项目用到了moment+antd+fullcalendar,想把moment替换成dayjs,现在项目中utcOffset参数都是用的string,替换起来有点麻烦,还有可能引发其它bug。 |
You can make a custom plugin to fix this at present.
|
will this bug fixed? |
True, would you like pulling request for this? |
Hey @iamkun 👋 . I wanted to contribute to the project and saw this issue still open and labeled as a good first issue, which is a great place to start for newcomers to the project (such as I am). I'd like to provide a PR for this issue. Many thanks! 🎉 |
@ognjenjevremovic you are most welcome. Ref here #1085 (comment) |
Provide support string support to utcOffset method. Valid string values formats for utcOffset method are +HH:mm, -HH:mm, +HHmm and -HHmm. ✅ Closes: iamkun#1085
Extend the current suite of utc unit tests by providing unit tests for the utcOffset method with string arguments. ✅ Closes: iamkun#1085
🎉 This issue has been resolved in version 1.10.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
如题
The text was updated successfully, but these errors were encountered: