-
Notifications
You must be signed in to change notification settings - Fork 0
Sentry: Turn on auto instrument server funcs #1561
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
CR 👍 I think this is the right thing, but it's hard for me to believe we aren't instrumenting with sentry at all except for the places where we do it explicitly. deploy_block 👍 on looking at those explicit places and ensuring we won't be double-reporting. |
Sentry's server function auto-instrumentation should capture these errors for us.
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Great suggestion! I did a quick audit of the places we explicitly use sentry, and I think these were the only potential double-captures. Our un_deploy_block ✌🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
Nice work!
I'm not sure why this was turned off, and it doesn't seem to make any difference with it on, but let's turn it back on.
https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#configure-server-side-auto-instrumentation
qa_req 0
CC @danielbeardsley
Connects #1491