Explicitly capture getServerSideProps exceptions
#1504
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
357.24 KB (🟡 +3.61 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load |
|---|---|---|
/myPage |
290 B |
357.52 KB |
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/_error |
467 B (🟢 -196 B) |
357.7 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Catches and reports `getServerSideProps` errors to sentry explicitly. This is an attempt to workaround a potential bug in Sentry: getsentry/sentry-javascript#7602
|
dev_block ✌🏻 on getting it to actually report the exception 😞 |
|
I really would have expected the sentry plugin to register an unhandled rejection event handler: Maybe we need to? Or maybe we aren't activating the plugin correctly? |
masonmcelvain
force-pushed
the
explicitly-capture-serverside-props-exceptions
branch
from
a77434b to
3e10ee7
Compare
frontend/helpers/next-helpers.ts
Outdated
| }); | ||
| }); | ||
| }; | ||
| process.on('unhandledRejection', (reason) => { |
There was a problem hiding this comment.
I think we shouldn't be doing this inside the withSentry() call. Otherwise, if you use withSentry() more than once it will subscribe multiple times. Vercel is kinda special in that they only run one next.js page per process, but not every environment is like that.
I think we should do it at the module level (sentry.client.config and sentry.server.config)
There was a problem hiding this comment.
Ah yea good call. This implementation didn't report to Sentry, nor did I see the logs, but I will try it in the config file.
There was a problem hiding this comment.
Womp womp still no dice when registered in sentry.server.config
In theory `withSentry` can be called more than once, but we only want to register one unhandled rejection listener per process. This registers the listener in the sentry server configuration, which is evaluated only once.
getServerSidePropsQA
Assuming #1492 hasn't been closed yet, visit the following url on a Vercel preview
and verify that an error shows up in react-commerce-dev similar to this one.
Closes #1491