Fix environment validators #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow any casing style - use Basic th by default if the string is left empty - set some default values for user-password pair for BasicAuth Signed-off-by: Marek Pikuła <[email protected]>
Should give better insight into the validation error. Signed-off-by: Marek Pikuła <[email protected]>
It should be more permissive and fall back to current time if format error is detected, Signed-off-by: Marek Pikuła <[email protected]>
Signed-off-by: Marek Pikuła <[email protected]>
Signed-off-by: Marek Pikuła <[email protected]>
|
BTW, why do you use Jenkins for building the images instead of GitHub Actions? It would make it much easier to debug ad integrate the building in (possibly) integrated CI tests in the future. GitHub Actions have really nice infrastructure for building Docker images. If you wish, I could look into that. |
|
it's just what I'm familiar with :) I'd gladly move to Github Actions, just need time to learn it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issues with BUILD_TIME and AUTH_TYPE validation.
Please double-check if it works before releasing it – especially the modification in Jenkinsfile. It should work by looking at https://stackoverflow.com/a/50095241/2929726, but I have no means to test it.
Should fix #88