Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3427 - Treat manifest warnings as warnings #3429

Merged
merged 2 commits into from
Nov 16, 2023
Merged

#3427 - Treat manifest warnings as warnings #3429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd0597
feat: treat warnings as warnings during aapt2 build
iBotPeaches Nov 16, 2023
6745aa6
test: add invalid fragment to manifest to confirm warning
iBotPeaches Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions brut.apktool/apktool-lib/src/main/java/brut/androlib/AaptInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ private void invokeAapt2(File apkFile, File manifest, File resDir, File rawDir,

cmd.add("--no-compile-sdk-metadata");

// #3427 - Ignore stricter parsing during aapt2
cmd.add("--warn-manifest-validation");

if (mApkInfo.sparseResources) {
cmd.add("--enable-sparse-encoding");
}
Expand Down
1 change: 1 addition & 0 deletions brut.apktool/apktool-lib/src/test/resources/aapt2/testapp/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
android:name="android.accessibilityservice"
android:resource="@xml/accessibility_service_config" />
</service>
<fragment android:name=".views.Issue3427"/>
<meta-data name="test_int_as_string" value="\ 12345" />
<meta-data name="test_int" value="12345" />
</application>
Expand Down