Upgrade com.github.johnrengelman:shadow to 8.1.1 #3255
Conversation
iBotPeaches
force-pushed
the
Update-shadow-to-8.1.1
branch
from
bac7ff2 to
2243ec3
Compare
iBotPeaches
changed the title
build.gradle.kts
Outdated
| maven { | ||
| url = uri("https://plugins.gradle.org/m2/") | ||
| } |
There was a problem hiding this comment.
Isn't this the same as gradlePluginPortal?
There was a problem hiding this comment.
This is how it was written at https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow
| } | ||
|
|
||
| apply(plugin = "com.github.johnrengelman.shadow") |
There was a problem hiding this comment.
Do you need to apply this? If it was attached to build script classpath its already there for building.
There was a problem hiding this comment.
again, this is how it was at https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow
There was a problem hiding this comment.
Looks like that says two different methods though and you have both, so just a bit lost.
|
@Phone-Guru - Thanks for spotting this out of date version, but I went ahead and did what I was trying to explain. Its tough to follow online docs because they don't really fully show all the ways a plugin works. They don't show buildscript vs runtime dependencies and suffer in groovy vs kotlin. So we wouldn't really go anywhere just taking the examples online. Unfortunately Gradle has a mix of a lot of old/new docs around. So take a look at this diff if you are curious what I did - #3259 |
No description provided.