-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Gradle Kotlin DSL #3249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fully rewritten from scratch by myself - no longer including license header on build files
The license plugin doesn't really work in Kotlin DSL and is abandoned. I couldn't find an alternative. So will attach a patch and revisit. Not to worried about license headers in files. Index: build.gradle.kts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build.gradle.kts b/build.gradle.kts
--- a/build.gradle.kts (revision 4469973fc700b89ee4f5834289d8e51841cacdc6)
+++ b/build.gradle.kts (date 1691149714052)
@@ -1,3 +1,4 @@
+import nl.javadude.gradle.plugins.license.LicenseExtension
import java.io.ByteArrayOutputStream
val baksmaliVersion by extra("3.0.3")
@@ -42,11 +43,31 @@
}
allprojects {
+ apply(plugin = "com.github.hierynomus.license")
+
repositories {
mavenCentral()
google()
}
+
+ configure<LicenseExtension> {
+ header = rootProject.file("brut.j.common/src/templates/HEADER.txt")
+ exclude("**/android/content/res/*.java")
+ exclude("**/android/util/*.java")
+ include("**/*.java")
+ mapping(mapOf("java" to "SLASHSTAR_STYLE"))
+ skipExistingHeaders = true
+ strictCheck = true
+
+ ext.set("year", 2010)
+ ext.set("brut", "Ryszard Wiśniewski")
+ ext.set("brutEmail", "[email protected]")
+ ext.set("ibot", "Connor Tumbleson")
+ ext.set("ibotEmail", "[email protected]")
+ }
}
+
+gradle.startParameter.excludedTaskNames += listOf("licenseFormatMain", "licenseFormatTest")
subprojects {
apply(plugin = "java")
@@ -109,4 +130,3 @@
mavenVersion = version
project.logger.lifecycle("Building RELEASE (${gitBranch}): ${apktoolVersion}}")
}
- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3245
License check/format- not possible