test: add failing/passing sparse/not-sparse test

[iBotPeaches]

This has a sparse packed and not application - iBotPeaches/TestApks@a09e2ca

fixes: #3199

[iBotPeaches]

I'm confident in the tests here as they fail if I revert fix, but I'll leave this open for a few hours if you'd like to confirm @IgorEisberg

[IgorEisberg]

Works perfectly here, thanks for the quick patch.

[IgorEisberg]

One question regarding

            if (! mResTable.getSparseResources()) {
                mResTable.setSparseResources(true);
            }

Isn't the if check redundant? It's just setting a boolean, doesn't seem like making sure it's not set has much of a purpose.

[iBotPeaches]

Isn't the if check redundant? It's just setting a boolean, doesn't seem like making sure it's not set has much of a purpose.

Yeah since that function has evolved to just a bool scalar set - it probably doesn't need that check anymore since its very cheap to do.

[IgorEisberg]

Yeah since that function has evolved to just a bool scalar set - it probably doesn't need that check anymore since its very cheap to do.

Oh, I missed that piece of history. In any case, since I decompile/recompile whole ROMs I can confidently say that this was the last broken piece of the puzzle - can't find any other regressions. Neat release.

[iBotPeaches]

Oh, I missed that piece of history. In any case, since I decompile/recompile whole ROMs I can confidently say that this was the last broken piece of the puzzle - can't find any other regressions. Neat release.

Yeah sorry about that, but I figured at some point I needed to rewrite some lower parts of code. I knew there was a chance of some regressions, but now I understand it far more than past and can iterate a bit quicker.

[IgorEisberg]

Yeah sorry about that, but I figured at some point I needed to rewrite some lower parts of code. I knew there was a chance of some regressions, but now I understand it far more than past and can iterate a bit quicker.

All par for the course, that's how development goes. I actually use a flavor of Apktool that I customized especially for proper MIUI handling (including the Xiaomi-invented "nxhdpi" specifier), but always try to make a pull request for generic/non-MIUI fixes that others could use. ;)