Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 14 - Grammatical Inflection #3369

Closed
3 tasks done
iBotPeaches opened this issue Oct 4, 2023 · 12 comments · Fixed by #3374
Closed
3 tasks done

Android 14 - Grammatical Inflection #3369

iBotPeaches opened this issue Oct 4, 2023 · 12 comments · Fixed by #3374
Milestone
v2.9.0

Comments

@iBotPeaches
Copy link
Owner

iBotPeaches commented Oct 4, 2023 •
edited
Loading

Steps

  • Docs
  • Sample
  • Patch

aosp-mirror/platform_frameworks_base@02d8919

Returns the user preference for the grammatical gender. Will be GRAMMATICAL_GENDER_NOT_SPECIFIED or GRAMMATICAL_GENDER_NEUTRAL or GRAMMATICAL_GENDER_FEMININE or GRAMMATICAL_GENDER_MASCULINE.
This was referenced Oct 4, 2023
Merged
Closed
@iBotPeaches
Copy link
Owner Author

aapt1 does NOT have patches for this. So we are going to move to aapt2 as default now. This is first release that didn't have parity in terms of qualifiers.

@iBotPeaches
Copy link
Owner Author

aapt2 is default now - 679c133

Just waiting on my AOSP downloads for android-14.0.0_r2 to complete to resume rebuilding aapt2 for this.

@iBotPeaches iBotPeaches added this to the v2.9.0 milestone Oct 6, 2023
@iBotPeaches iBotPeaches mentioned this issue Oct 7, 2023
Merged
@HassanMirza01
Copy link

HassanMirza01 commented Oct 8, 2023 •
edited
Loading

not sure what causing issue but apps are not recompiling fine now, giving conflicts error for resources in xxxhdpi and same in xxhdpi for A13 MIUI apps

same were working fine before these last 4-5commits

@iBotPeaches
Copy link
Owner Author

not sure what causing issue but apps are not recompiling fine now, giving conflicts error for resources in xxxhdpi and same in xxhdpi for A13 MIUI apps

same were working fine before these last 4-5commits

So it has the new gender qualifiers? Confused why its posted in this issue with no details.

@HassanMirza01
Copy link

HassanMirza01 commented Oct 8, 2023 •
edited
Loading

image
just wanted to report in case you didn't checked yet?
i pulled repo and noticed A14 bringup stuff, so may be those changes linked here,

@iBotPeaches
Copy link
Owner Author

I have removed and did not patch any MIUI changes this time, so those changes are intended and will remain broken. Sorry.

@HassanMirza01
Copy link

HassanMirza01 commented Oct 8, 2023 •
edited
Loading

may be its not MIUI thing ? cause different dpi's have different values for same property like i posted above. so if it find same value in 2 different folders like xxxhdpi and xxhdpi it gonna give originally defind already error,

checking with some apks from apkmirror

@iBotPeaches
Copy link
Owner Author

I'm 100% sure its MIUI since I see godzillaui and thats the exact patch I did not bring forward.

@HassanMirza01
Copy link

HassanMirza01 commented Oct 8, 2023 •
edited
Loading

[] Recompiling framework-ext-res ...
I: Using Apktool v2.8.1-84-01cf954-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-ext-res/res/values-mcc9466-mnc9999/bools.xml: error: invalid configuration 'mcc9466-mnc9999'.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-ext-res/res/values-mcc9998-mnc9999/arrays.xml: error: invalid configuration 'mcc9998-mnc9999'.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_151017479878224505205319450418778287462.tmp, compile, --dir, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-ext-res/res, --legacy, -o, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-ext-res/build/resources.zip]
[] ---> Error recompiling framework-ext-res

[] Recompiling framework-res ...
I: Using Apktool v2.8.1-84-01cf954-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/res/values-mcc9460-mnc9000/bools.xml: error: invalid configuration 'mcc9460-mnc9000'.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/res/values-mcc9998-mnc9999/arrays.xml: error: invalid configuration 'mcc9998-mnc9999'.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/res/values-mcc9998-mnc9999/bools.xml: error: invalid configuration 'mcc9998-mnc9999'.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/res/values-mcc9998-mnc9999/strings.xml: error: invalid configuration 'mcc9998-mnc9999'.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_67438578434692150253702439342909193588.tmp, compile, --dir, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/res, --legacy, -o, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/framework-res/build/resources.zip]
[] ---> Error recompiling framework-res

[] Recompiling miui ...
I: Using Apktool v2.8.1-84-01cf954-SNAPSHOT
I: Checking whether sources has changed...
I: Checking whether resources has changed...
I: Building resources...
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/miui/AndroidManifest.xml:1: error: attribute 'package' in tag is not a valid Android package name: 'miui'.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_70261658252583623234017751202892414549.tmp, link, -o, /tmp/APKTOOL8442115316280994093.tmp, --package-id, 16, --min-sdk-version, 33, --target-sdk-version, 33, --rename-manifest-package, com.miui.core, --rename-instrumentation-target-package, com.miui.core, --version-code, 1200099, --version-name, 1.20.0.0, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --no-compile-sdk-metadata, -x, -e, /tmp/APKTOOL9684362941151896394.tmp, -0, arsc, -I, /home/hassanmirza01/apktools/.bin/temp/framework/1.apk, --manifest, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/miui/AndroidManifest.xml, /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/miui/build/resources.zip]
[] ---> Error recompiling miui

[*] Recompiling MiuiHome ...
I: Using Apktool v2.8.1-84-01cf954-SNAPSHOT
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Checking whether resources has changed...
I: Building resources...
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-mediumui-xhdpi/dimens.xml:5: error: resource 'dimen/workspace_cell_height' has a conflicting value for configuration (sw600dp-xhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-xhdpi/dimens.xml:22: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-mediumui-xhdpi/dimens.xml:6: error: resource 'dimen/workspace_cell_width' has a conflicting value for configuration (sw600dp-xhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-xhdpi/dimens.xml:26: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-mediumui-xhdpi/dimens.xml:7: error: resource 'dimen/workspace_icon_text_notification_size' has a conflicting value for configuration (sw600dp-xhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw600dp-xhdpi/dimens.xml:27: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/build/resources.zip@values-sw600dp-mediumui-xhdpi_dimens.arsc.flat: error: failed to merge resource table.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:8: error: resource 'dimen/folder_bottom_padding' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:3: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:9: error: resource 'dimen/folder_content_padding_left' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:4: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:11: error: resource 'dimen/folder_content_width' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:5: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:13: error: resource 'dimen/folder_top_padding' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:6: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:14: error: resource 'dimen/hotseats_height' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:7: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:22: error: resource 'dimen/workspace_cell_height' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:8: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:23: error: resource 'dimen/workspace_cell_padding_side' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:9: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:25: error: resource 'dimen/workspace_cell_width' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:10: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-xxhdpi/dimens.xml:26: error: resource 'dimen/workspace_icon_text_size' has a conflicting value for configuration (sw360dp-xxhdpi).
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-sw360dp-godzillaui-xxhdpi/dimens.xml:11: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/build/resources.zip@values-sw360dp-xxhdpi_dimens.arsc.flat: error: failed to merge resource table.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-godzillaui/dimens.xml:3: error: resource 'dimen/all_apps_scroller_text_size' has a conflicting value for configuration ().
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values/dimens.xml:100: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-godzillaui/dimens.xml:4: error: resource 'dimen/edit_mode_top_menu_text_view_margin_top' has a conflicting value for configuration ().
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values/dimens.xml:321: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-godzillaui/dimens.xml:5: error: resource 'dimen/hotseats_margin_top' has a conflicting value for configuration ().
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values/dimens.xml:451: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-godzillaui/dimens.xml:6: error: resource 'dimen/search_bar_margin_bottom' has a conflicting value for configuration ().
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values/dimens.xml:1509: note: originally defined here.
W: /home/hassanmirza01/apktools/alioth1408/_INPUT_APK/MiuiHome/res/values-godzillaui/dimens.xml:7: error: resource 'dimen/search_bar_margin_top' has a conflicting value for configuration ().

@HassanMirza01
Copy link

if all above errors are linked to same patch then its ok,

@iBotPeaches
Copy link
Owner Author

Well 2 things.

1.Yes it is.
2. aapt2 is default by now. You've probably used aapt1 with MIUI in past, so add --use-aapt1

@HassanMirza01
Copy link

Well 2 things.

1.Yes it is. 2. aapt2 is default by now. You've probably used aapt1 with MIUI in past, so add --use-aapt1

this worked bro, yes i just noticed i was not using any --use--aapt1 or 2 parameter so it was assuming aapt1 always before, setting aapt1 fixes these, thanks <3

iBotPeaches added a commit that referenced this issue Oct 8, 2023
@iBotPeaches
docs: add #3369 to release
83f0acd
iBotPeaches added a commit that referenced this issue Oct 8, 2023
@iBotPeaches
[Docs] Release 2.9.0 (#3375)
408a1fe 
* prep for release 2.9.0

* chore: linter

* docs: note w/ aapt1 usage

* docs: add #3369 to release

* build: update to latest of docusaurus 2.4.x

* fix: correct release post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Android 14 - Support for Grammatical Inflection iBotPeaches/Apktool
2 participants
@iBotPeaches @HassanMirza01