Skip to content

Commit

Permalink
build: lock gradle actions to specific versions (#3073)
Browse files Browse the repository at this point in the history
  • Loading branch information
@iBotPeaches
iBotPeaches authored May 22, 2023
1 parent 56b07d2 commit e53869c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ jobs:
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/wrapper-validation-action@v1.0.6
- name: Build and test
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v2.4.2
with:
arguments: build shadowJar proguard

Expand All @@ -94,7 +94,7 @@ jobs:
distribution: 'zulu'
java-version: 17
- name: Build
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v2.4.2
with:
arguments: build shadowJar proguard
- name: Upload
Expand Down

1 comment on commit e53869c

@iBotPeaches
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well your simplified version doesn't really include any of the if requirements that the duplication requires. So I see your point, but when you end up packing in all the if-clauses to ensure its proper flavor of Apktool, intended OS and proper branch - you have so much additional logic cluttered in the step. So I don't really see this as a needed improvement. The duplication is handled by Dependabot to update those together.

Please sign in to comment.