API: getTranscodeImagePath: adopt to less lenient PMS API #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMS long had ignored extra path components, but some time around 1.23.2.4600 this changed. It still ignores fragments though, so use those instead. Fixes issue iBaa#597.
|
Applied but did not fix the problem in my case. |
Huh, that's weird. Seems to be working perfectly fine on Have you tried looking at the logs of PMS? It should list the requests for thumbnails and note whether it was broken or not. Does it use the |
|
It works ok if I don't use plex.tv. But as soon as I login to plex.tv posters are not shown and play fails. |
|
I applied the fix and can confirm it works on an AppleTV 3 and PMS v1.23.2.4656 on a QNAP NAS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMS long had ignored extra path components, but some time around
1.23.2.4600 this changed. It still ignores fragments though, so use
those instead.
Fixes issue #597.