Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roster info message #6905

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Roster info message #6905

merged 1 commit into from
Dec 5, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Dec 5, 2024

Depends on #6899

Add a message under the students table when the list is generated from launches instead of a roster, so that teachers can better understand why some students may not be displayed in that case.

image

@acelaya acelaya changed the base branch from main to roster-sync-date December 5, 2024 14:17
@acelaya acelaya requested a review from robertknight December 5, 2024 14:18
@acelaya acelaya force-pushed the roster-info-message branch from ba82edb to 22a9372 Compare December 5, 2024 14:20
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It may be helpful to extend this with a link to a KB article that has more information about why/when we cannot fetch rosters.

@acelaya
Copy link
Contributor Author

acelaya commented Dec 5, 2024

It may be helpful to extend this with a link to a KB article that has more information about why/when we cannot fetch rosters.

There's actually one. I forgot to link there 🤦🏼

@acelaya acelaya force-pushed the roster-info-message branch from 22a9372 to 67509f0 Compare December 5, 2024 15:41
@acelaya acelaya force-pushed the roster-info-message branch from 67509f0 to c103f3e Compare December 5, 2024 15:46
@acelaya acelaya merged commit 345923d into roster-sync-date Dec 5, 2024
9 checks passed
@acelaya acelaya deleted the roster-info-message branch December 5, 2024 15:51
acelaya added a commit that referenced this pull request Dec 10, 2024
* Add roster sync indicator

* Add message when assignment students do not come from roster (#6905)
marcospri pushed a commit that referenced this pull request Dec 10, 2024
* Add roster sync indicator

* Add message when assignment students do not come from roster (#6905)
marcospri pushed a commit that referenced this pull request Dec 10, 2024
* Add roster sync indicator

* Add message when assignment students do not come from roster (#6905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants