Apply updates from cookiecutter

This automated commit applies the latest updates from our cookiecutters [1] to
this repo.

[1]: https://github.com/hypothesis/cookiecutters

.github/workflows/ci.yml

@@ -17,7 +17,6 @@ on:
       - 'requirements/dev.txt'
       - '.docker.env'
       - '**/.gitignore'
-      - '.python-version'
       - 'Dockerfile'
       - 'LICENSE'
       - '*.md'
@@ -93,7 +92,7 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: coverage
-          path: .coverage
+          path: .coverage.*
   Coverage:
     needs: tests
     runs-on: ubuntu-latest

.github/workflows/slack.yml

@@ -0,0 +1,17 @@
+name: Slack
+on:
+  workflow_run:
+    workflows: [CI]
+    types: [completed]
+    branches: [main]
+jobs:
+  on-failure:
+    runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'failure' }}    steps:
+      - name: Post to Slack
+        uses: slackapi/[email protected]
+        with:
+          channel-id: 'C4K6M7P5E'
+          slack-message: "A workflow run failed\n*Repo:* `${{ github.event.repository.full_name }}` (${{ github.event.repository.html_url }})\n*Workflow:* ${{ github.event.workflow.name }} (${{ github.event.workflow.html_url }})\n*Branch:* `${{ github.event.workflow_run.head_branch }}`\n*Commit:* `${{ github.event.workflow_run.head_commit.id }}`\n*Run:* ${{ github.event.workflow_run.html_url }}\n*Conclusion:* ${{ github.event.workflow_run.conclusion }}"
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

pyproject.toml

@@ -72,7 +72,9 @@ jobs = 0 # Use one process for CPU.
 load-plugins = [
     "pylint.extensions.bad_builtin",
     "pylint.extensions.check_elif",
+    "pylint.extensions.comparetozero",
     "pylint.extensions.docparams",
+    "pylint.extensions.emptystring",
     "pylint.extensions.mccabe",
     "pylint.extensions.overlapping_exceptions",
     "pylint.extensions.redefined_variable_type",
@@ -91,8 +93,6 @@ enable = [
     "deprecated-pragma",
     "useless-suppression",
     "use-symbolic-message-instead",
-    "use-implicit-booleaness-not-comparison-to-zero",
-    "use-implicit-booleaness-not-comparison-to-string"
 ]
 disable = [
     # Docstrings are encouraged but we don't want to enforce that everything

requirements/functests.in

@@ -7,4 +7,3 @@ factory-boy
 pytest-factoryboy
 h-matchers
 webtest
-filelock

requirements/lint.in

@@ -3,7 +3,7 @@ pip-sync-faster
 -r tests.txt
 -r functests.txt
 toml # Needed for pydocstyle to support pyproject.toml.
-pylint>=3.0.0a7
+pylint
 pydocstyle
 pycodestyle
 -r bddtests.txt

requirements/tests.in

@@ -1,13 +1,11 @@
 pip-tools
 pip-sync-faster
 -r prod.txt
-pytest-coverage
+coverage[toml]
 pytest
 factory-boy
 pytest-factoryboy
 h-matchers
 httpretty
 freezegun
 aioresponses
-pytest-xdist[psutil]
-filelock

tests/pyproject.toml

@@ -4,7 +4,9 @@ jobs = 0 # Use one process for CPU.
 load-plugins = [
     "pylint.extensions.bad_builtin",
     "pylint.extensions.check_elif",
+    "pylint.extensions.comparetozero",
     "pylint.extensions.docparams",
+    "pylint.extensions.emptystring",
     "pylint.extensions.mccabe",
     "pylint.extensions.overlapping_exceptions",
     "pylint.extensions.redefined_variable_type",

tox.ini

@@ -16,11 +16,11 @@ setenv =
     dev: SENTRY_ENVIRONMENT = {env:SENTRY_ENVIRONMENT:dev}
     dev: NEW_RELIC_APP_NAME = {env:NEW_RELIC_APP_NAME:lms}
     dev: NEW_RELIC_ENVIRONMENT = {env:NEW_RELIC_ENVIRONMENT:dev}
+    dev,tests,functests: PYTHONDEVMODE = {env:PYTHONDEVMODE:1}
     tests,functests: PYTEST_PLUGINS = tests.pytest_plugins.factory_boy
     dev: ALEMBIC_CONFIG = {env:ALEMBIC_CONFIG:conf/alembic.ini}
     dev: DATABASE_URL = {env:DATABASE_URL:postgresql://postgres@localhost:5433/postgres}
     tests: DATABASE_URL = {env:UNITTESTS_DATABASE_URL:postgresql://postgres@localhost:5433/lms_tests}
-    dev,tests,functests: PYTHONDEVMODE = {env:PYTHONDEVMODE:1}
     functests: DATABASE_URL = {env:FUNCTESTS_DATABASE_URL:postgresql://postgres@localhost:5433/lms_functests}
     # Make `import lms` work in `make shell`.
     dev: PYTHONPATH = .
@@ -92,7 +92,7 @@ commands =
     lint: pylint --rcfile=tests/pyproject.toml tests
     lint: pydocstyle lms tests bin
     lint: pycodestyle lms tests bin
-    tests: python -m pytest --cov --numprocesses logical --failed-first --new-first --no-header --quiet {posargs:tests/unit/}
+    tests: coverage run -m pytest --failed-first --new-first --no-header --quiet {posargs:tests/unit/}
     functests: python -m pytest --failed-first --new-first --no-header --quiet {posargs:tests/functional/}
     coverage: -coverage combine
     coverage: coverage report