chore: Upgrade gradle version #84
Conversation
| @@ -1,4 +1,4 @@ | |||
| rootProject.name = "query-service" | |||
| rootProject.name = "query-service-root" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
the build issue is due to bad config in the proto plugin that's being caught with the stricter gradle, we've run into it before.
Source sets for api project can add in the generated dirs, but not duplicate the default source sets (which is causing the double inclusion):
sourceSets {
main {
java {
srcDirs("build/generated/source/proto/main/java", "build/generated/source/proto/main/grpc_java")
}
}
}| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-all.zip | |||
There was a problem hiding this comment.
given that we're upgrading gradle, can we go to 7.2?
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 81.62% 81.62%
Complexity 391 391
=========================================
Files 37 37
Lines 1513 1513
Branches 162 162
=========================================
Hits 1235 1235
Misses 205 205
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
No description provided.